-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make much more flexible #1
Conversation
* Able to express times in local zone. * Able to shift time to another zone correctly. * Can select and transform multiple date fields at the same time. * Introduces/demos new feature of openaps to ease how uses store and retrieve their configuration from config. * Can save timezone (or None), as well as list of date fields.
Examples uses:
|
|
||
def rezone (self, dt): | ||
if (self.adjust == 'missing' and dt.tzinfo == None) or self.adjust == 'replace': | ||
return dt.replace(tzinfo=self.timezone) | ||
dt = dt.replace(tzinfo=self.timezone) # .astimezone(self.timezone) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaces the timezone, such that the "datetime" expressed is now in this new timezone rather than the old one.
When a datetime that does not know about a timezone gains the ability to reason about timezones, calling isoformat( )
on the object will result in the similar behavior as javascript's dt.toISOString( )
: the date will be rendered as iso 8601, in Zulu/UTC timezone, with the hours shifted from the local timezone appropriately. The inverse happens with parsing a zone-aware iso8601 string: the parser determines the difference between your local time and the described zone, and produces the correct wall-time as a result. By default, printing it out again will shift it back to the "canonical" Zulu/UTC zone-aware representation. While the tools heavily prefer UTC/Zulu time, it can be useful to print iso8601 date strings with the local time correctly described locally.
The following dt.astimezone
line, in contrast, "shifts" the hours from timezone A to timezone B appropriately while pinning the behavior of isoformat( )
to produce an iso8601 format in the new timezone (not Zulu/UTC). This can be useful in printing a valid zone-aware 8601 string in the local time, given a valid is8601 datetime that is already (correctly) zone aware in another zone, or missing a zone altogether.
These two behaviors can be invoked by the tool independently, to control whether or not to shift times vs simply printing them in local time vs UTC time.
This fixes a bug which now allows clock's use to be registered as a report properly.
their configuration from config.